Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

H003 schematic support #154

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

H003 schematic support #154

wants to merge 4 commits into from

Conversation

jplot
Copy link
Contributor

@jplot jplot commented Aug 27, 2024

No description provided.

@jplot
Copy link
Contributor Author

jplot commented Sep 26, 2024

Hi @tobischo,
You can start reviewing the code.
I'm waiting to finalize tests with our financial partner before putting the PR on ready.

@tobischo
Copy link
Collaborator

I am really excited to see that you also added EBICS 3 🤩

I had that on my list as a potential followup after your changes.
Will review as soon as I have time and also start testing whether the 2.5 cases still work that I am responsible
I might have access on a test API to 3.0 as well 🤔

Copy link
Collaborator

@tobischo tobischo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks great.

I haven't tested it yet against an EBICS API, so I cannot speak to whether it is still working (yet).

I think it is missing some test cases, e.g. around the signature algorithm handling and using a different EBICS version

@@ -6,7 +6,7 @@
EPICS is a ruby implementation of the [EBICS](https://www.ebics.org/) (Electronic Banking Internet
Communication Standard).

It supports EBICS 2.5.
It supports EBICS 2.4, 2.5 and 3.0.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the readme could reflect which one is the default when initializing a new or existing client and how to work with another version

lib/epics/header_request.rb Show resolved Hide resolved
spec/key_spec.rb Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants